Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-28556: Updates to typing module #2076

Merged
merged 3 commits into from
Jun 10, 2017

Conversation

ilevkivskyi
Copy link
Member

This PR contains two updates to typing module:

  • Support ContextManager on all versions (original PR by Jelle Zijlstra).
  • Add generic AsyncContextManager.

This needs to be backported to 3.5 and 3.6 (preferably before Monday).

Attn: @gvanrossum

@mention-bot
Copy link

@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zware, @serhiy-storchaka and @rhettinger to be potential reviewers.

@ilevkivskyi ilevkivskyi reopened this Jun 10, 2017
@gvanrossum gvanrossum merged commit 29fda8d into python:master Jun 10, 2017
@gvanrossum
Copy link
Member

Take it away, Mariatta the orchestra leader!

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
This PR contains two updates to typing module:

- Support ContextManager on all versions (original PR by Jelle Zijlstra).
- Add generic AsyncContextManager..
(cherry picked from commit 29fda8d)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
This PR contains two updates to typing module:

- Support ContextManager on all versions (original PR by Jelle Zijlstra).
- Add generic AsyncContextManager..
(cherry picked from commit 29fda8d)
@Mariatta
Copy link
Member

No prob :)
Done in GH-2088 and GH-2087

@ilevkivskyi
Copy link
Member Author

Thank you Mariatta!

@ilevkivskyi ilevkivskyi deleted the update-typing-26 branch June 10, 2017 21:37
Mariatta added a commit that referenced this pull request Jun 10, 2017
This PR contains two updates to typing module:

- Support ContextManager on all versions (original PR by Jelle Zijlstra).
- Add generic AsyncContextManager..
(cherry picked from commit 29fda8d)
Mariatta added a commit that referenced this pull request Jun 10, 2017
This PR contains two updates to typing module:

- Support ContextManager on all versions (original PR by Jelle Zijlstra).
- Add generic AsyncContextManager..
(cherry picked from commit 29fda8d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants