Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port fcntl module to multiphase initialization #20540

Merged
merged 1 commit into from
Jun 1, 2020
Merged

bpo-1635741: Port fcntl module to multiphase initialization #20540

merged 1 commit into from
Jun 1, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 30, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner May 30, 2020 14:42
@corona10
Copy link
Member Author

@vstinner Can you please take a look?

shihai1991
shihai1991 approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: )

vstinner
vstinner approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any shared state, great!

@corona10 corona10 merged commit e9684fa into python:master Jun 1, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@corona10 corona10 deleted the bpo-1635741-fcntl branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot