bpo-40750: Support -d flag in the new parser #20340

pablogsal · 2020-05-24T01:43:12Z

https://bugs.python.org/issue40750

Add NEWS entry

lysnikolaou

I really like the output. One question: Would the non-ASCII characters create problems for people, whose terminals do not support UTF-8?

pablogsal · 2020-05-24T20:00:34Z

I really like the output. One question: Would the non-ASCII characters create problems for people, whose terminals do not support UTF-8?

I would say it would be very uncommon that anyone would run python with -d (requires a debug build) in a terminal that does not support UTF-8 but I don't feel very strongly about those characters if anyone sees other problems.

gvanrossum · 2020-05-24T20:19:59Z

I'm personally a big believer in ASCII. I don't know how to type those other characters and have to Google their Unicode values every time.

pablogsal · 2020-05-24T20:40:04Z

I'm personally a big believer in ASCII. I don't know how to type those other characters and have to Google their Unicode values every time.

Fair enough, let's change them. Some suggestions for substituting characters or error/acceptance messages (the current ones are basically placeholders)?

Tools/peg_generator/pegen/c_generator.py

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

pablogsal · 2020-05-24T20:58:35Z

Ok, I have substituted the non-ascii characters for some close equivalents (- and + and ERROR in case of some error propagation). Also, I have simplified the macro and used @lysnikolaou suggestion.

lysnikolaou

Great! Thanks!

pablogsal · 2020-05-24T21:02:36Z

Example of the output now:

       > star_expressions[0-0]: star_expression
       + star_expressions[0-3]: star_expression succeeded!
       > augassign[3-3]: '+='
       - augassign[3-3]: '+=' failed!
       > augassign[3-3]: '-='
       - augassign[3-3]: '-=' failed!
       > augassign[3-3]: '*='
       - augassign[3-3]: '*=' failed!
       > augassign[3-3]: '@='
       - augassign[3-3]: '@=' failed!
       > augassign[3-3]: '/='
       - augassign[3-3]: '/=' failed!
       > augassign[3-3]: '%='
       - augassign[3-3]: '%=' failed!
       > augassign[3-3]: '&='
       - augassign[3-3]: '&=' failed!
       > augassign[3-3]: '|='
       - augassign[3-3]: '|=' failed!
       > augassign[3-3]: '^='
       - augassign[3-3]: '^=' failed!
       > augassign[3-3]: '<<='
       - augassign[3-3]: '<<=' failed!
       > augassign[3-3]: '>>='
       - augassign[3-3]: '>>=' failed!
       > augassign[3-3]: '**='
       - augassign[3-3]: '**=' failed!
       > augassign[3-3]: '//='
       - augassign[3-3]: '//=' failed!
      - invalid_assignment[0-0]: star_expressions augassign (yield_expr | star_expressions) failed!
     - assignment[0-0]: invalid_assignment failed!
    - small_stmt[0-0]: assignment failed!
    > small_stmt[0-0]: star_expressions
     > star_expressions[0-0]: star_expression ((',' star_expression))+ ','?
      > _loop1_71[3-3]: (',' star_expression)
       > _tmp_139[3-3]: ',' star_expression
       - _tmp_139[3-3]: ',' star_expression failed!
      - _loop1_71[3-3]: (',' star_expression) failed!
     - star_expressions[0-0]: star_expression ((',' star_expression))+ ','? failed!
     > star_expressions[0-0]: star_expression ','
     - star_expressions[0-0]: star_expression ',' failed!
     > star_expressions[0-0]: star_expression
     + star_expressions[0-3]: star_expression succeeded!
    + small_stmt[0-3]: star_expressions succeeded!
   + simple_stmt[0-4]: small_stmt !';' NEWLINE succeeded!
  + statement_newline[0-4]: simple_stmt succeeded!
 + interactive[0-4]: statement_newline succeeded!

miss-islington · 2020-05-25T17:39:14Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

(cherry picked from commit 800a35c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

bedevere-bot · 2020-05-25T17:39:26Z

GH-20392 is a backport of this pull request to the 3.9 branch.

(cherry picked from commit 800a35c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

bedevere-bot · 2020-05-25T18:04:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 800a35c.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/129/builds/1129) and take a look at the build logs.
Check if the failure is related to this commit (800a35c) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/129/builds/1129

Failed tests:

test_peg_generator

Failed subtests:

test_syntax_error_for_string - test.test_peg_generator.test_c_parser.TestCParser
test_left_recursion - test.test_peg_generator.test_c_parser.TestCParser
test_error_in_rules - test.test_peg_generator.test_c_parser.TestCParser
test_with_stmt_with_paren - test.test_peg_generator.test_c_parser.TestCParser
test_c_parser - test.test_peg_generator.test_c_parser.TestCParser
test_lookahead - test.test_peg_generator.test_c_parser.TestCParser
test_ternary_operator - test.test_peg_generator.test_c_parser.TestCParser
test_gather_action_ast - test.test_peg_generator.test_c_parser.TestCParser
test_if_stmt_action - test.test_peg_generator.test_c_parser.TestCParser
test_advanced_left_recursive - test.test_peg_generator.test_c_parser.TestCParser
test_pass_stmt_action - test.test_peg_generator.test_c_parser.TestCParser
test_gather - test.test_peg_generator.test_c_parser.TestCParser
test_cut - test.test_peg_generator.test_c_parser.TestCParser
test_mutually_left_recursive - test.test_peg_generator.test_c_parser.TestCParser
test_same_name_different_types - test.test_peg_generator.test_c_parser.TestCParser
test_nasty_mutually_left_recursive - test.test_peg_generator.test_c_parser.TestCParser
test_negative_lookahead - test.test_peg_generator.test_c_parser.TestCParser
test_return_stmt_noexpr_action - test.test_peg_generator.test_c_parser.TestCParser

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

394 tests OK.

10 slowest tests:

test_mmap: 9 min 9 sec
test_largefile: 5 min 19 sec
test_io: 4 min 30 sec
test_unparse: 3 min 7 sec
test_multiprocessing_spawn: 3 min 3 sec
test_tokenize: 2 min 56 sec
test_concurrent_futures: 2 min 4 sec
test_unicodedata: 1 min 43 sec
test_capi: 1 min 42 sec
test_lib2to3: 1 min 36 sec

1 test failed:
test_peg_generator

30 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_wait3 test_wait4
test_xxtestfuzz test_zipfile64

1 re-run test:
test_peg_generator

Total duration: 17 min 20 sec

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 229, in test_nasty_mutually_left_recursive
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 317, in test_same_name_different_types
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 377, in test_syntax_error_for_string
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 181, in test_gather
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 343, in test_with_stmt_with_paren
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 255, in test_gather_action_ast
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 129, in test_c_parser
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 497, in link
    self.spawn([self.linker] + ld_args)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 507, in spawn
    return super().spawn(cmd)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 910, in spawn
    spawn(cmd, dry_run=self.dry_run)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\spawn.py", line 81, in spawn
    raise DistutilsExecError(
distutils.errors.DistutilsExecError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 244, in test_return_stmt_noexpr_action
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 204, in test_advanced_left_recursive
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 141, in test_lookahead
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 270, in test_pass_stmt_action
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 153, in test_negative_lookahead
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 361, in test_ternary_operator
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 193, in test_left_recursion
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 404, in test_error_in_rules
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 297, in test_if_stmt_action
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 216, in test_mutually_left_recursive
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 169, in test_cut
    self.run_test(grammar_source, test_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "D:\buildarea\3.x.bolen-windows10\build\Tools\peg_generator\pegen\build.py", line 91, in compile_c_extension
    cmd.run()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\command\build_ext.py", line 551, in build_extension
    self.compiler.link_shared_object(
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\ccompiler.py", line 713, in link_shared_object
    self.link(CCompiler.SHARED_OBJECT, objects,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\_msvccompiler.py", line 499, in link
    raise LinkError(msg)
distutils.errors.LinkError: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.13.26128\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120

pablogsal · 2020-05-25T18:20:34Z

Seems that some version Microsoft compiler does not like the linkage of Py_DebugFlag, will investigate and submit a fix.

Activate debug flag for the new parser

509fb8e

the-knights-who-say-ni added the CLA signed label May 24, 2020

bedevere-bot added the awaiting core review label May 24, 2020

pablogsal requested review from gvanrossum and lysnikolaou May 24, 2020 01:45

pablogsal force-pushed the parser_debug branch 3 times, most recently from 1cdeb88 to 1939494 Compare May 24, 2020 02:40

Add indentation to the output for easy tracking of the stack

294e4c6

Add NEWS entry

pablogsal force-pushed the parser_debug branch from 1939494 to 294e4c6 Compare May 24, 2020 02:43

lysnikolaou reviewed May 24, 2020

View reviewed changes

Tools/peg_generator/pegen/c_generator.py Outdated Show resolved Hide resolved

lysnikolaou reviewed May 24, 2020

View reviewed changes

Tools/peg_generator/pegen/c_generator.py Outdated Show resolved Hide resolved

pablogsal and others added 2 commits May 24, 2020 21:52

Update Tools/peg_generator/pegen/c_generator.py

e184eaa

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

Remove non-ascii characters and simplify macro

2dfb790

lysnikolaou approved these changes May 24, 2020

View reviewed changes

pablogsal merged commit 800a35c into python:master May 25, 2020

bedevere-bot removed the awaiting core review label May 25, 2020

pablogsal added the needs backport to 3.9 only security fixes label May 25, 2020

pablogsal deleted the parser_debug branch May 25, 2020 17:39

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2020

bpo-40750: Support -d flag in the new parser (pythonGH-20340)

fd45ccb

(cherry picked from commit 800a35c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

bedevere-bot removed the needs backport to 3.9 only security fixes label May 25, 2020

miss-islington added a commit that referenced this pull request May 25, 2020

bpo-40750: Support -d flag in the new parser (GH-20340)

82da2c3

(cherry picked from commit 800a35c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-40750: Support -d flag in the new parser #20340

bpo-40750: Support -d flag in the new parser #20340

pablogsal commented May 24, 2020 •

edited by bedevere-bot

Loading

lysnikolaou left a comment

pablogsal commented May 24, 2020

gvanrossum commented May 24, 2020

pablogsal commented May 24, 2020

pablogsal commented May 24, 2020

lysnikolaou left a comment

pablogsal commented May 24, 2020

miss-islington commented May 25, 2020

bedevere-bot commented May 25, 2020

bedevere-bot commented May 25, 2020

pablogsal commented May 25, 2020

bpo-40750: Support -d flag in the new parser #20340

bpo-40750: Support -d flag in the new parser #20340

Conversation

pablogsal commented May 24, 2020 • edited by bedevere-bot Loading

lysnikolaou left a comment

Choose a reason for hiding this comment

pablogsal commented May 24, 2020

gvanrossum commented May 24, 2020

pablogsal commented May 24, 2020

pablogsal commented May 24, 2020

lysnikolaou left a comment

Choose a reason for hiding this comment

pablogsal commented May 24, 2020

miss-islington commented May 25, 2020

bedevere-bot commented May 25, 2020

bedevere-bot commented May 25, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

pablogsal commented May 25, 2020

pablogsal commented May 24, 2020 •

edited by bedevere-bot

Loading