Skip to content

bpo-40669: Use requirements.pip when installing PEG dependencies #20194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
May 18, 2020
Merged

bpo-40669: Use requirements.pip when installing PEG dependencies #20194

pablogsal merged 1 commit into from
May 18, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 18, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal mentioned this pull request May 18, 2020
Merged
@pablogsal pablogsal closed this May 18, 2020
@pablogsal pablogsal reopened this May 18, 2020
lysnikolaou
lysnikolaou approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want -U?

@pablogsal
Copy link
Member Author

pablogsal commented May 18, 2020

Do we also want -U?

Given that this code won't trigger unless there is no venv I don't think it matters.

@lysnikolaou
Copy link
Member

lysnikolaou commented May 18, 2020

Do we also want -U?

Given that this code won't trigger unless there is no venv I don't think it matters.

Ok, go for it!

@pablogsal pablogsal merged commit 3764069 into python:master May 18, 2020
@pablogsal pablogsal deleted the bpo-40669 branch May 18, 2020 22:37
@miss-islington
Copy link
Contributor

miss-islington commented May 19, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2020
@pablogsal @miss-islington
bpo-40669: Use requirements.pip when installing PEG dependencies (pyt…
a08549c 
…honGH-20194)

(cherry picked from commit 3764069)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 19, 2020

GH-20203 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 19, 2020
@miss-islington @pablogsal
bpo-40669: Use requirements.pip when installing PEG dependencies (GH-…
3d06282 
…20194)

(cherry picked from commit 3764069)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@pablogsal @arturoescaip
bpo-40669: Use requirements.pip when installing PEG dependencies (pyt…
aeab26a 
…honGH-20194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pablogsal @lysnikolaou @miss-islington @bedevere-bot @gvanrossum @ambv @the-knights-who-say-ni