Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31033: Use _PyErr_ChainStackItem() inside gen_send_ex(). #20173

Merged
merged 1 commit into from
May 18, 2020
Merged

bpo-31033: Use _PyErr_ChainStackItem() inside gen_send_ex(). #20173

merged 1 commit into from
May 18, 2020

Conversation

cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 18, 2020 •
edited by bedevere-bot
Loading

This is a tiny refactoring follow-up to PR #19951 / bpo-31033.

_PyErr_ChainStackItem() was just added in PR #19951, so it can now be used in genobject.c.

(This isn't needed for bpo-31033. I'm linking it only because it's related.)

https://bugs.python.org/issue31033

@cjerdonek
Use _PyErr_ChainStackItem() inside gen_send_ex().
bfaa13c 
_PyErr_ChainStackItem was just added in pythonGH-19951 (for bpo-31033).
@cjerdonek cjerdonek requested a review from 1st1 as a code owner May 18, 2020 11:49
@cjerdonek cjerdonek changed the title Use _PyErr_ChainStackItem() inside gen_send_ex(). [trivial] Use _PyErr_ChainStackItem() inside gen_send_ex(). May 18, 2020
@cjerdonek cjerdonek changed the title [trivial] Use _PyErr_ChainStackItem() inside gen_send_ex(). bpo-31033: Use _PyErr_ChainStackItem() inside gen_send_ex(). May 18, 2020
@cjerdonek cjerdonek merged commit ff7a8b0 into python:master May 18, 2020
@cjerdonek cjerdonek deleted the use-py-err-chain-stack-item branch May 18, 2020 22:36
@ambv ambv added the needs backport to 3.9 only security fixes label May 19, 2020
@miss-islington
Copy link
Contributor

Thanks @cjerdonek for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-20202 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 19, 2020
ambv pushed a commit that referenced this pull request May 19, 2020
@miss-islington @cjerdonek
Use _PyErr_ChainStackItem() inside gen_send_ex(). (GH-20173) (#20202)
f02c304 
_PyErr_ChainStackItem was just added in GH-19951 (for bpo-31033).
(cherry picked from commit ff7a8b0)

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@cjerdonek @arturoescaip
Use _PyErr_ChainStackItem() inside gen_send_ex(). (pythonGH-20173)
a5ee319 
_PyErr_ChainStackItem was just added in pythonGH-19951 (for bpo-31033).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjerdonek @miss-islington @bedevere-bot @1st1 @ambv @the-knights-who-say-ni