bpo-30605: Fix compiling binary regexs with BytesWarnings enabled. #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running our unit tests with `-bb` enabled triggered this failure.
|
+1 |
serhiy-storchaka
requested changes
Jun 9, 2017
Lib/test/test_re.py
Outdated
| @@ -1368,7 +1368,7 @@ def test_inline_flags(self): | |||
| self.assertTrue(re.match(p, lower_char)) | |||
| self.assertEqual( | |||
| str(warns.warnings[0].message), | |||
| 'Flags not at the start of the expression %s' % p | |||
| "Flags not at the start of the expression '%s'" % p | |||
There was a problem hiding this comment.
Just use %r.
And add a test for bytes pattern b'A(?i)'.
|
Thanks for your feedback @serhiy-storchaka ! Addressed your comments. |
serhiy-storchaka
requested changes
Jun 9, 2017
Misc/ACKS
Outdated
| @@ -1685,6 +1685,7 @@ Jakub Wilk | |||
| Gerald S. Williams | |||
| Jason Williams | |||
| John Williams | |||
| Roy Willams | |||
Misc/NEWS
Outdated
| @@ -646,6 +646,9 @@ Library | |||
| - bpo-29851: importlib.reload() now raises ModuleNotFoundError if the | |||
| module lacks a spec. | |||
|
|
|||
| - bpo-30605: re.compile() no longer raises a BytesWarning when compiling a | |||
| bytes instance. | |||
There was a problem hiding this comment.
Add "Patch by Roy Williams."
"... when compiling a bytes instance with misplaced inline modifier." Or something like.
And usually new entries are added at the begin of a section, so they are listed in the reversed chronological order.
|
Thanks again @serhiy-storchaka for taking a look. I promise usually I spell my own name correctly 😆 ! |
serhiy-storchaka
approved these changes
Jun 10, 2017
|
Thank you for your contribution @rowillia. Do you mind to backport this fix to 3.6? |
serhiy-storchaka
added
needs backport to 3.6
type-bug
|
Sounds good to me @serhiy-storchaka, thanks for your help landing this. |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 15, 2017
…ed. (pythonGH-2016) Running our unit tests with `-bb` enabled triggered this failure.. (cherry picked from commit 171b9a3)
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running our unit tests with
-bbenabled triggered this failure.