bpo-40334: Make the PyPegen* and PyParser* APIs more consistent #19839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to make both APIs more consistent by doing the following: - Remove the `PyPegen_CodeObjectFrom*` functions, which weren't used and will probably not be needed. Functions like `Py_CompileStringObject` can be used instead. - Include a `const char *filename` parameter in `PyPegen_ASTFromString`. - Rename `PyPegen_ASTFromFile` to `PyPegen_ASTFromFilename`, because its signature is not the same with `PyParser_ASTFromFile`. Closes #we-like-parsers#104.
Exquisite 👌 |
pablogsal
reviewed
May 1, 2020
And that's with rewriting all the arguments to appear one per line in pegen_interface.h! 😄 |
|
@lysnikolaou Thanks also for adding good commit messages: it makes writing the final commit message much easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make both APIs more consistent by doing the following:
PyPegen_CodeObjectFrom*functions, which weren't usedand will probably not be needed. Functions like
Py_CompileStringObjectcan be used instead.const char *filenameparameter inPyPegen_ASTFromString.PyPegen_ASTFromFiletoPyPegen_ASTFromFilename, becauseits signature is not the same with
PyParser_ASTFromFile.Closes we-like-parsers#104.
https://bugs.python.org/issue40334