bpo-34990: Treat the pyc header's mtime in compileall as an unsigned int

[ammaraskar]

Created with @matrixise's blessing to continue their work. This is an alternative to changing the timestamps to 64-bit. Should last for a while.

I didn't update Tools/checkpyc.py like the original PR there pending a decision on a bug I made to remove it

https://bugs.python.org/issue34990

[vstinner]

I would prefer to mimick importlib._bootstrap_external which uses:

def _pack_uint32(x):
    """Convert a 32-bit integer to little-endian."""
    return (int(x) & 0xFFFFFFFF).to_bytes(4, 'little')

[serhiy-storchaka]

See my comments to #9892. If they be addressed it would be merged a long time ago.

[ammaraskar]

Updated to just drop the number down to the lower 32-bits like importlib._bootstrap_external

Not sure if the new test I added is safe though, as in can we assume that file-systems in general will support timestamps of larger than 32-bit?

[serhiy-storchaka]

👍

[ammaraskar]

@serhiy-storchaka Just a little ping, is this ready to go or are there any other changes that should be made here?

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @ammaraskar for commit 91b54fd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

[serhiy-storchaka]

Sorry, I missed that this PR was not merged yet.

[serhiy-storchaka]

@ammaraskar, please merge this branch with main.

[miss-islington]

Thanks @ammaraskar for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

[bedevere-bot]

GH-27928 is a backport of this pull request to the 3.10 branch.

[bedevere-bot]

GH-27929 is a backport of this pull request to the 3.9 branch.

[ammaraskar]

Thank you for merging Serhiy, I was asleep when you LGTM'd :)