Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it #19648

Merged
merged 1 commit into from
Oct 20, 2020
Merged

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it #19648

merged 1 commit into from
Oct 20, 2020

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Apr 22, 2020 •
edited by bedevere-bot
Loading

@hroncok hroncok requested a review from terryjreedy as a code owner April 22, 2020 07:38
@hroncok hroncok mentioned this pull request Apr 22, 2020
Merged
@terryjreedy
Copy link
Member

Thank you. I will take care of this when I can, and add the idlelib/NEWS.txt item.

@taleinat
Copy link
Contributor

Referring to @terryjreedy's request on the original PR GH-17473:

@taleinat Ned disposed of the .icns issue. Do you currently have a respository on Windows? If so, can you verify that IDLE runs with the current patch and new .ico file?

Tested now, works great on my Windows 10 machine.

@zooba zooba merged commit faddc74 into python:master Oct 20, 2020
@hroncok hroncok deleted the idle256ico branch October 20, 2020 12:25
@miss-islington
Copy link
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22823 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
@hroncok @miss-islington
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
d9e6242 
…GH-19648)

(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
@hroncok @miss-islington
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
29c1edb 
…GH-19648)

(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-bot
Copy link

GH-22824 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 20, 2020
miss-islington added a commit that referenced this pull request Oct 20, 2020
@miss-islington @hroncok
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
d84e411 
(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington added a commit that referenced this pull request Oct 21, 2020
@miss-islington @hroncok
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
871c6cc 
(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@hroncok @adorilson
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
6b4980f 
…GH-19648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hroncok @terryjreedy @taleinat @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni