Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port mmap module to multiphase initialization #19459

Merged
merged 4 commits into from
Jun 5, 2020
Merged

bpo-1635741: Port mmap module to multiphase initialization #19459

merged 4 commits into from
Jun 5, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 10, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 changed the title Port mmap module to multiphase initialization bpo-1635741: Port mmap module to multiphase initialization Apr 10, 2020
@corona10 corona10 requested a review from vstinner April 10, 2020 15:31
shihai1991
shihai1991 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

vstinner
vstinner approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. mmap code would deserve better error handling, but that can be addressed in a separated PR.

Apart static types, I don't anything which would be shared by multiple module instances/interpreters.

Modules/mmapmodule.c Show resolved Hide resolved
Modules/mmapmodule.c Outdated Show resolved Hide resolved
@corona10 corona10 force-pushed the bpo-1635741-mmap branch from 623259b to d3b55d7 Compare June 5, 2020 13:52
vstinner
vstinner reviewed Jun 5, 2020
View reviewed changes
Modules/mmapmodule.c Outdated Show resolved Hide resolved
vstinner
vstinner approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the PyExc_OSError bug.

@corona10 corona10 merged commit 3ad52e3 into python:master Jun 5, 2020
@corona10
Copy link
Member Author

corona10 commented Jun 5, 2020

@vstinner @shihai1991 Thanks for the reviews!

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
bpo-1635741: Port mmap module to multiphase initialization (pythonGH-…
3e8fe21 
…19459)
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@corona10 corona10 deleted the bpo-1635741-mmap branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot