Skip to content

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5125b4
Cython files don't compile on Mingw-w64 64-bit fix
BenjaminLiuPenrose Apr 3, 2020
866dbe9
skip news
BenjaminLiuPenrose Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2020-01-24-09-15-41.bpo-8901.hVnhGO.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
Ignore the Windows registry when the ``-E`` option is used.
Add Mingw-w64 64-bit windows machine, fix issue
in https://bugs.python.org/issue40167
Comment on lines +2 to +3
Copy link
Contributor

@taleinat taleinat Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to create a new NEWS entry file rather than adding this to an existing one. Use blurb-it or blurb.

5 changes: 5 additions & 0 deletions PC/pyconfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ WIN32 is still required for the locale module.


/* Compiler specific defines */
#ifdef __MINGW32__
Copy link
Contributor

@taleinat taleinat Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why and when this is needed.

#ifdef _WIN64
#define MS_WIN64
#endif
#endif

/* ------------------------------------------------------------------------*/
/* Microsoft C defines _MSC_VER */
Expand Down