Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39930: Fix MSBuild detection for Build Tools #18938

Merged
merged 5 commits into from
Mar 11, 2020
Merged

bpo-39930: Fix MSBuild detection for Build Tools #18938

merged 5 commits into from
Mar 11, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 11, 2020 •
edited
Loading

Ensure we detect Build Tools installs using the newer logic, and skip looking in the registry for VS 2017.

https://bugs.python.org/issue39930

@zooba zooba requested a review from a team as a code owner March 11, 2020 18:57
@zooba zooba added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section skip news labels Mar 11, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit 5a56006 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit e7d917f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit d828efc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit daab287 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@miss-islington
Copy link
Contributor

@zooba: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 894adc1 into python:master Mar 11, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2020
@zooba @miss-islington
bpo-39930: Fix MSBuild detection for Build Tools (pythonGH-18938)
7076f4d 
Ensure we detect Build Tools installs using the newer logic, and skip looking in the registry for VS 2017.
(cherry picked from commit 894adc1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-18943 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 894adc18b4fb7246b762276a50a332c0e4f0e0f0 3.7

@miss-islington miss-islington self-assigned this Mar 11, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 894adc18b4fb7246b762276a50a332c0e4f0e0f0 3.7

@zooba zooba deleted the bpo-39930 branch March 12, 2020 16:47
miss-islington added a commit that referenced this pull request Mar 12, 2020
@miss-islington @zooba
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
35ae5d9 
Ensure we detect Build Tools installs using the newer logic, and skip looking in the registry for VS 2017.
(cherry picked from commit 894adc1)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit to zooba/cpython that referenced this pull request Mar 12, 2020
@zooba
bpo-39930: Fix MSBuild detection for Build Tools (pythonGH-18938)
ac32383 
Ensure we detect Build Tools installs using the newer logic, and skip looking in the registry for VS 2017.
@bedevere-bot
Copy link

GH-18962 is a backport of this pull request to the 3.7 branch.

zooba added a commit that referenced this pull request Mar 13, 2020
@zooba
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
c05e491 
Ensure we detect Build Tools installs using the newer logic, and skip looking in the registry for VS 2017.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miss-islington miss-islington

Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @bedevere-bot @miss-islington @the-knights-who-say-ni