Skip to content

bpo-39855: Fix test_subprocess if nobody user doesn't exist #18781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

bpo-39855: Fix test_subprocess if nobody user doesn't exist #18781

merged 1 commit into from
Mar 5, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 4, 2020 •
edited by bedevere-bot
Loading

test_subprocess.test_user() now skips the test on an user name if the
user name doesn't exist. For example, skip the test if the user
"nobody" doesn't exist on Linux.

https://bugs.python.org/issue39855

@vstinner
bpo-39855: Fix test_subprocess if nobody user doesn't exist
e43a43a 
test_subprocess.test_user() now skips the test on an user name if the
user name doesn't exist. For example, skip the test if the user
"nobody" doesn't exist on Linux.
@vstinner vstinner requested a review from gpshead as a code owner March 4, 2020 22:03
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Mar 4, 2020
@vstinner
Copy link
Member Author

vstinner commented Mar 4, 2020

cc @gpshead

@mcepl
Copy link
Contributor

mcepl commented Mar 5, 2020

Yeah, that’s better solution.

aeros
aeros approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the most reasonable solution for non-existent users is to simply skip the test.

@vstinner vstinner merged commit f7b5d41 into python:master Mar 5, 2020
@vstinner vstinner deleted the subprocess_nobody branch March 5, 2020 13:29
sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 5, 2020
@sthagen
Merge pull request #303 from python/master
1732799 
bpo-39855: Fix test_subprocess if nobody user doesn't exist (pythonGH-18781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros aeros approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @mcepl @aeros @the-knights-who-say-ni @bedevere-bot