Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE doc: improve Startup failure subsection. #18771

Merged
merged 2 commits into from
Mar 6, 2020
Merged

IDLE doc: improve Startup failure subsection. #18771

merged 2 commits into from
Mar 6, 2020

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Mar 3, 2020

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 3, 2020
@JulienPalard
Copy link
Member

LGTM

@tirkarthi tirkarthi requested a review from terryjreedy March 4, 2020 15:05
akuchling
akuchling previously requested changes Mar 5, 2020
View reviewed changes
Doc/library/idle.rst Outdated
@@ -689,7 +689,7 @@ When IDLE first starts, it attempts to read user configuration files in
``~/.idlerc/`` (~ is one's home directory). If there is a problem, an error
message should be displayed. Leaving aside random disk glitches, this can
be prevented by never editing the files by hand, using the configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change still leaves the grammar of the sentence mangled. It should be something like "by never editing the files by hand, instead using the configuration dialog under Options."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for seeing what I was trying to say. I made this change, with '.' instead of ','.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@terryjreedy terryjreedy self-assigned this Mar 6, 2020
@terryjreedy
Update idle.rst
43f8320 
Make additional small changes in the preceding and following paragraphs.
@terryjreedy
Copy link
Member

Jules, thank you for this PR reporting my incomplete editing. After incorporating Andrew's suggestion, I also improved a bit the paragraphs before and after.

@terryjreedy terryjreedy dismissed akuchling’s stale review March 6, 2020 01:21

I incorporated Andrew's suggestion.

@terryjreedy terryjreedy changed the title Fixed double Options in idle.rst IDLE doc: improve Startup failure subsection. Mar 6, 2020
@terryjreedy terryjreedy merged commit ce305d6 into python:master Mar 6, 2020
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2020
@Seluj78 @miss-islington
IDLE doc: improve Startup failure subsection. (pythonGH-18771)
01aa343 
Eliminate repeat of 'Options', reported by Jules Lasne, and improve wording elsewhere.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ce305d6)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot
Copy link

GH-18794 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-18795 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2020
@Seluj78 @miss-islington
IDLE doc: improve Startup failure subsection. (pythonGH-18771)
dfce317 
Eliminate repeat of 'Options', reported by Jules Lasne, and improve wording elsewhere.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ce305d6)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
miss-islington added a commit that referenced this pull request Mar 6, 2020
@miss-islington @Seluj78
IDLE doc: improve Startup failure subsection. (GH-18771)
3c9cec0 
Eliminate repeat of 'Options', reported by Jules Lasne, and improve wording elsewhere.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ce305d6)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
miss-islington added a commit that referenced this pull request Mar 6, 2020
@miss-islington @Seluj78
IDLE doc: improve Startup failure subsection. (GH-18771)
da9ee00 
Eliminate repeat of 'Options', reported by Jules Lasne, and improve wording elsewhere.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ce305d6)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@terryjreedy
Copy link
Member

Backports are merged.

@terryjreedy terryjreedy mentioned this pull request Mar 7, 2020
Merged
ned-deily pushed a commit that referenced this pull request Mar 10, 2020
@miss-islington @Seluj78 @ned-deily
IDLE doc: improve Startup failure subsection. (GH-18771)
1e85e1a 
Eliminate repeat of 'Options', reported by Jules Lasne, and improve wording elsewhere.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ce305d6)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@akuchling akuchling akuchling left review comments

Assignees

@terryjreedy terryjreedy

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Seluj78 @JulienPalard @bedevere-bot @terryjreedy @miss-islington @akuchling @the-knights-who-say-ni