-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39699: Don't silence make on Azure and Github CIs #18583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18583 +/- ##
===========================================
+ Coverage 82.11% 83.13% +1.01%
===========================================
Files 1956 1571 -385
Lines 589357 414787 -174570
Branches 44458 44458
===========================================
- Hits 483953 344827 -139126
+ Misses 95756 60336 -35420
+ Partials 9648 9624 -24
Continue to review full report at Codecov.
|
With the macOS fix I mentioned in the comment, I approve of this PR. Whoever is around can feel free to merge it. |
f5dc930
to
55665a5
Compare
Thanks for the review Steve! :) |
Thanks @ammaraskar for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry, @ammaraskar and @zooba, I could not cleanly backport this to |
Sorry @ammaraskar and @zooba, I had trouble checking out the |
GH-18670 is a backport of this pull request to the 3.8 branch. |
GH-18671 is a backport of this pull request to the 3.7 branch. |
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
Doc tests remain disabled for 3.7 Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
Removing the
-s
flag allows us to see what build commands were invoked to produce the targets and which compilation step produced errors/warnings.https://bugs.python.org/issue39699