Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39245: Switch to public API for Vectorcall #18460

Merged
merged 2 commits into from
Feb 11, 2020
Merged

bpo-39245: Switch to public API for Vectorcall #18460

merged 2 commits into from
Feb 11, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 11, 2020 •
edited by bedevere-bot
Loading

Continuation of #17893

The NEWS entry was added there.

https://bugs.python.org/issue39245

@encukou
Use public vectorcall API (automated change)
3814ff5 
Generated automatically with:

    for name in \
        PyObject_Vectorcall \
        Py_TPFLAGS_HAVE_VECTORCALL \
        PyObject_VectorcallMethod \
        PyVectorcall_Function \
        PyObject_CallOneArg \
        PyObject_CallMethodNoArgs \
        PyObject_CallMethodOneArg \
    ;
    do
        echo $name
        git grep -lwz _$name | xargs -0 sed -i "s/\b_$name\b/$name/g"
    done

    old=_PyObject_FastCallDict
    new=PyObject_VectorcallDict
    git grep -lwz $old | xargs -0 sed -i "s/\b$old\b/$new/g"
@encukou
Clean-up
fb6b104 
- Revert changes to in docs & news
- Revert changes to backcompat defines in headers
- Nudge misaligned comments
@encukou encukou requested a review from vstinner February 11, 2020 13:02
vstinner
vstinner approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #18460 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18460     +/-   ##
=========================================
  Coverage   82.11%   82.12%             
=========================================
  Files        1955     1954      -1     
  Lines      588951   583606   -5345     
  Branches    44428    44428             
=========================================
- Hits       483637   479262   -4375     
+ Misses      95668    94698    -970     
  Partials     9646     9646
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 325 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea45ae...fb6b104. Read the comment docs.

@encukou encukou merged commit ffd9753 into python:master Feb 11, 2020
@encukou encukou deleted the vectorcall-callsites branch February 11, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@gpshead gpshead Awaiting requested review from gpshead

@methane methane Awaiting requested review from methane

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@pablogsal pablogsal Awaiting requested review from pablogsal

@rhettinger rhettinger Awaiting requested review from rhettinger

@warsaw warsaw Awaiting requested review from warsaw

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@encukou @vstinner @the-knights-who-say-ni @bedevere-bot