Ignore NEWS snippets in code coverage stats #18194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
approved these changes
Jan 27, 2020
|
If coverage tests are run on other branches, you may want to backport your change to 3.7 and 3.8. |
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry @ncoghlan, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 7023288) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
|
GH-18200 is a backport of this pull request to the 3.7 branch. |
|
Good point! |
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 7023288) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
|
GH-18201 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 7023288) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 7023288) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to work out what was wrong with the code coverage stats on #18066,
I realised we weren't ignoring the
Misc/NEWS.dsubdirectory correctly.