Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39161: Document multi-phase init modules under Py_NewInterpreter() #17896

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Jan 7, 2020

+ this also adds a stronger warning against sharing objects between (sub-)interpreters.

https://bugs.python.org/issue39161

Automerge-Triggered-By: @encukou

This also adds a stronger warning against sharing objects between
(sub-)interpreters.
@encukou encukou added docs Documentation in the Doc dir skip news labels Jan 7, 2020
@ncoghlan ncoghlan changed the title bpo-37194: Document multi-phase init modules under Py_NewInterpreter() bpo-39161: Document multi-phase init modules under Py_NewInterpreter() Jan 7, 2020
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of copy-editing comments inline.

@ncoghlan
Copy link
Contributor

ncoghlan commented Jan 7, 2020

Note: I also fixed up the b.p.o links to refer the right issue (this had been confused with the VectorCall one).

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 6c5d661 into python:master Jan 9, 2020
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2020
pythonGH-17896)

\+ this also adds a stronger warning against sharing objects between (sub-)interpreters.

https://bugs.python.org/issue39161
(cherry picked from commit 6c5d661)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot
Copy link

GH-17918 is a backport of this pull request to the 3.8 branch.

@encukou encukou deleted the pynewinterpreter-docs branch January 9, 2020 12:06
miss-islington added a commit that referenced this pull request Jan 9, 2020
GH-17896)

\+ this also adds a stronger warning against sharing objects between (sub-)interpreters.

https://bugs.python.org/issue39161
(cherry picked from commit 6c5d661)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
pythonGH-17896)

\+ this also adds a stronger warning against sharing objects between (sub-)interpreters.



https://bugs.python.org/issue39161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants