Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace links in howto/pyporting.rst with sphinx references #17781

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

hoefling
Copy link
Contributor

@hoefling hoefling commented Jan 1, 2020

The howto/pyporting.rst documentation uses hardcoded links to internal pages. This results in minor rendering issues. This change replaces the hardcoded links with suitable Sphinx roles.

This is the second and last PR that replaces hardcoded links to internal pages (the first one was #11730). I did create neither an issue on BPO nor a news entry as the fix is IMO a trivial one.

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@csabella csabella merged commit e6ae90d into python:master Jan 5, 2020
@miss-islington
Copy link
Contributor

Thanks @hoefling for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17844 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17845 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
…-17781)

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…-17781)

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants