bpo-39151: Simplify dfs in the assembler#17733
Merged
pablogsal merged 5 commits intopython:masterfrom Jun 28, 2020
Merged
Conversation
3a50605 to
e047388
Compare
Member
Author
|
As a bonus, this does hilariously jumpy code compilation faster: masterpatched |
brettcannon
approved these changes
Jan 6, 2020
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Contributor
|
@pablogsal, should this be merged since it was approved? |
Member
Author
|
Thanks, @csabella for the ping! :) |
pablogsal
commented
Jun 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplification has the advantage that we don't stack overflow if the amount of jumps in the blocks is insane (maybe some autogenerated code).
The current code already relies on the topological order of the blocks, this PR just continues with that assumption to further simplify.
https://bugs.python.org/issue39151