Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39041: Add GitHub Actions support #17594

Merged
merged 12 commits into from
Dec 16, 2019
Merged

bpo-39041: Add GitHub Actions support #17594

merged 12 commits into from
Dec 16, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Dec 13, 2019 •
edited by bedevere-bot
Loading

@zooba zooba changed the title Add GitHub Actions support bpo-39041: Add GitHub Actions support Dec 13, 2019
@zooba zooba mentioned this pull request Dec 13, 2019
Closed
brettcannon
brettcannon approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make sure to add doc-building workflow. I would also build against -latest for the OSs. And I think you might be able to use ${runs-on} as the title so it states the OS that way.

@zooba
Copy link
Member Author

zooba commented Dec 13, 2019

I changed the VM images to "latest", but it still seems best to have static labels. I also added the coverage test run after we know the Ubuntu tests have passed, but I don't know that we'll want the extra delay.

Maybe if I split it into a separate check we can make the coverage run optional? We'll have to merge this one first though. Once I get the docs workflow in then we can do that and iterate on the coverage run.

@brettcannon
Copy link
Member

Yeah, I would split the coverage run out as a separate thing as we don't rely on it to prevent coverage slippage.

@zooba
Copy link
Member Author

zooba commented Dec 13, 2019

From my other PR (where I've enabled the builds), it looks like this:
image

@zooba zooba merged commit a76ba36 into python:master Dec 16, 2019
@zooba zooba deleted the actions branch December 16, 2019 18:46
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@zooba @miss-islington
bpo-39041: Add GitHub Actions support (pythonGH-17594)
0e5216d 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-17868 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17869 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@zooba @miss-islington
bpo-39041: Add GitHub Actions support (pythonGH-17594)
0036aad 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Jan 6, 2020
@miss-islington @zooba
bpo-39041: Add GitHub Actions support (GH-17594)
0048833 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Jan 6, 2020
@miss-islington @zooba
bpo-39041: Add GitHub Actions support (GH-17594)
acf5e5f 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@zooba @shihai1991
bpo-39041: Add GitHub Actions support (pythonGH-17594)
4e89676
farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#17594: MINGW: preset configure defaults
8af8b02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni