Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PYTHONUTF8 to commandline usage. #17587

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Add PYTHONUTF8 to commandline usage. #17587

merged 2 commits into from
Dec 14, 2019

Conversation

methane
Copy link
Member

@methane methane commented Dec 13, 2019

No description provided.

@methane methane requested a review from vstinner December 13, 2019 12:07
vstinner
vstinner reviewed Dec 13, 2019
View reviewed changes
Python/initconfig.c Outdated Show resolved Hide resolved
@methane @vstinner
Update Python/initconfig.c
205fdd4 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@methane methane merged commit 95826c7 into python:master Dec 14, 2019
@methane methane deleted the help-pythonutf8 branch December 14, 2019 05:27
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Sorry, @methane, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 95826c773a9004fc5b3c89de55f800504685ab21 3.7

@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17598 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2019
@methane @miss-islington
Add PYTHONUTF8 to commandline usage. (pythonGH-17587)
aa6a3ba 
Co-Authored-By: Victor Stinner <vstinner@python.org>
(cherry picked from commit 95826c7)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot
Copy link

GH-17599 is a backport of this pull request to the 3.7 branch.

methane added a commit that referenced this pull request Dec 14, 2019
@miss-islington @methane
Add PYTHONUTF8 to commandline usage. (GH-17587)
4a5db78 
Co-Authored-By: Victor Stinner <vstinner@python.org>
(cherry picked from commit 95826c7)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
vstinner pushed a commit that referenced this pull request Dec 14, 2019
@methane @vstinner
Add PYTHONUTF8 to commandline usage. (GH-17587) (GH-17599)
26892c7 
Co-Authored-By: Victor Stinner <vstinner@python.org>
(cherry picked from commit 95826c7)
@vstinner
Copy link
Member

Thanks @methane, I always forget to update all places for new cmdline options and new env vars ;-)

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 18, 2019
@methane @ned-deily
Add PYTHONUTF8 to commandline usage. (pythonGH-17587) (pythonGH-17599)
b4f98f4 
Co-Authored-By: Victor Stinner <vstinner@python.org>
(cherry picked from commit 95826c7)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@methane @vstinner @shihai1991
Add PYTHONUTF8 to commandline usage. (pythonGH-17587)
a759b4f 
Co-Authored-By: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees

@methane methane

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni