Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38439: Add 256px IDLE icon #17473

Merged
merged 9 commits into from
Apr 22, 2020
Merged

bpo-38439: Add 256px IDLE icon #17473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3bf5497
bpo-38439: Add 256px IDLE icon
hroncok Dec 5, 2019
09d626d
Unly use the 256 icon as png, gif looks ugly
hroncok Mar 1, 2020
89fb222
Only make the idle ico from the png files
hroncok Mar 1, 2020
d39ea14
Add IDLE icons README
hroncok Mar 10, 2020
5f6d700
Recreate macOS icons
hroncok Mar 10, 2020
b56002d
Make the ico in ImageMagick, for more reproducible documentation.
hroncok Mar 10, 2020
8c66b3d
Explain why there is no 48x48 in idle.icns
hroncok Mar 10, 2020
1d943a0
Delete the outdated idle.icns
hroncok Apr 18, 2020
3a5c89d
No ico change, as originally intended
hroncok Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/idlelib/Icons/README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
The IDLE icons are from https://bugs.python.org/issue1490384

Created by Andrew Clover.

The original sources are available from Andrew's website:
https://www.doxdesk.com/software/py/pyicons.html

Various different formats and sizes are available at this GitHub Pull Request:
https://github.com/python/cpython/pull/17473
Binary file removed Lib/idlelib/Icons/idle.icns
View file
Open in desktop
Binary file not shown.
Binary file added Lib/idlelib/Icons/idle_256.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 7 additions & 2 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,9 +1486,14 @@ def main():
iconfile = os.path.join(icondir, 'idle.ico')
root.wm_iconbitmap(default=iconfile)
elif not macosx.isAquaTk():
ext = '.png' if TkVersion >= 8.6 else '.gif'
if TkVersion >= 8.6:
ext = '.png'
sizes = (16, 32, 48, 256)
else:
ext = '.gif'
sizes = (16, 32, 48)
iconfiles = [os.path.join(icondir, 'idle_%d%s' % (size, ext))
for size in (16, 32, 48)]
for size in sizes]
icons = [PhotoImage(master=root, file=iconfile)
for iconfile in iconfiles]
root.wm_iconphoto(True, *icons)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2019-12-05-14-20-53.bpo-38439.j_L2PI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add a 256×256 pixel IDLE icon to support more modern environments. Created by Andrew Clover.
Delete the unused macOS idle.icns icon file.
1 change: 1 addition & 0 deletions PCbuild/lib.pyproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,6 +1585,7 @@
<Content Include="idlelib\Icons\idle_32.png" />
<Content Include="idlelib\Icons\idle_48.gif" />
<Content Include="idlelib\Icons\idle_48.png" />
<Content Include="idlelib\Icons\idle_256.png" />
<Content Include="idlelib\Icons\minusnode.gif" />
<Content Include="idlelib\Icons\openfolder.gif" />
<Content Include="idlelib\Icons\plusnode.gif" />
Expand Down