bpo-38903: Remove #if block that is not used on parsetok.c #17365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On parsetok.c we can see a #if that has not effect on compilation
shihai1991
approved these changes
Nov 25, 2019
|
I ping to @brettcannon because on commit e3944a5 added it, to understand the context and to know if is safety remove it. |
|
@eamanu best I can think of is it was left there as an example. Otherwise that was over a decade ago so 🤷♂️ |
pablogsal
approved these changes
Jan 13, 2020
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jan 13, 2020
Remove unused functions in Parser/parsetok.c (pythonGH-17365)
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On parsetok.c we can see a #if that has not effect on compilation
https://bugs.python.org/issue38903