bpo-22257: Private C-API for main interpreter initialization (PEP 432). #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericsnowcurrently, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @methane and @loewis to be potential reviewers. |
ericsnowcurrently
force-pushed
the
pep432
branch
5 times, most recently
from
6da8498 to
90c5a8f
Compare
ericsnowcurrently
changed the title
zooba
reviewed
May 24, 2017
Python/pythonrun.c
Outdated
| @@ -28,6 +35,7 @@ | |||
| #ifdef MS_WINDOWS | |||
| #undef BYTE | |||
| #include "windows.h" | |||
| /* TODO: This is duped in shutdown.c Find a way to merge them */ | |||
zooba
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Patch by Nick Coghlan)
(based on #1772)
This patch introduces the bulk of the remaining changes specified by PEP 432. These are introduced here as "private" C-API while the PEP is discussed. Regardless of the status of the PEP, the changes here are an improvement to interpreter startup. As such we are making the changes now, but keeping the C-API private.