Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed capital letter in parameter in stdtypes.rst #17218

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Removed capital letter in parameter in stdtypes.rst #17218

merged 1 commit into from
Nov 21, 2019

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Nov 18, 2019 •
edited by miss-islington
Loading

Automerge-Triggered-By: @csabella

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 18, 2019
@vsajip vsajip changed the title Removed capital letter in parametter in stdtypes.rst Removed capital letter in parameter in stdtypes.rst Nov 18, 2019
@brandtbucher
Copy link
Member

@willingc

corona10
corona10 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Seluj78

Since order is a parameter name this PR looks correct!
Thanks for the contribution to CPython :)

Core developers will take a look at this PR also, Let's wait for until than!

@corona10 corona10 requested a review from willingc November 20, 2019 15:11
csabella
csabella approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Seluj78!

@miss-islington miss-islington merged commit 6db2fb7 into python:master Nov 21, 2019
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@Seluj78 @miss-islington
Removed capital letter in parameter in stdtypes.rst (pythonGH-17218)
812c12e 
Automerge-Triggered-By: @csabella
(cherry picked from commit 6db2fb7)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot
Copy link

GH-17307 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @Seluj78
Removed capital letter in parameter in stdtypes.rst (GH-17218)
ac99ea4 
Automerge-Triggered-By: @csabella
(cherry picked from commit 6db2fb7)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Seluj78
Removed capital letter in parameter in stdtypes.rst (pythonGH-17218)
1d10a4d 
Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Seluj78 @shihai1991
Removed capital letter in parameter in stdtypes.rst (pythonGH-17218)
2509543 
Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@csabella csabella csabella approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@willingc willingc Awaiting requested review from willingc

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Seluj78 @brandtbucher @miss-islington @bedevere-bot @corona10 @csabella @the-knights-who-say-ni