Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing coma after end of list in subprocess.rst #17217

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Added missing coma after end of list in subprocess.rst #17217

merged 3 commits into from
Nov 19, 2019

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Nov 18, 2019 •
edited by miss-islington
Loading

Automerge-Triggered-By: @csabella

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 18, 2019
Seluj78
Seluj78 commented Nov 18, 2019
View reviewed changes
Copy link
Contributor Author

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm dumb sometimes

brandtbucher
brandtbucher requested changes Nov 18, 2019
View reviewed changes
@Seluj78 @brandtbucher
Apply suggestions from code review
6fc035b 
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@miss-islington miss-islington merged commit f25875a into python:master Nov 19, 2019
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @Seluj78, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f25875af425a3480e557aaedf49c3bb867bcbd5d 3.8

@miss-islington miss-islington self-assigned this Nov 19, 2019
Seluj78 added a commit to Seluj78/cpython that referenced this pull request Nov 26, 2019
@Seluj78
[3.8] Added missing coma after end of list in subprocess.rst (pythonG…
000b852 
…H-17217)

Automerge-Triggered-By: @csabella
(cherry picked from commit f25875a)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot
Copy link

GH-17389 is a backport of this pull request to the 3.8 branch.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Seluj78
Added missing coma after end of list in subprocess.rst (pythonGH-17217)
facf017 
Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Seluj78 @shihai1991
Added missing coma after end of list in subprocess.rst (pythonGH-17217)
91746dc 
Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Seluj78 @miss-islington @bedevere-bot @csabella @brandtbucher @the-knights-who-say-ni