Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor formatting improvements and fixes to idle.rst #17165

Merged
merged 2 commits into from
Jan 5, 2020

Conversation

taleinat
Copy link
Contributor

No description provided.

Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on these! LGTM

@terryjreedy
Copy link
Member

Thank you both for the changes and review. I checked that idle.html looks good (better), with no added glitches, in our viewer.

@terryjreedy terryjreedy merged commit d6c08db into python:master Jan 5, 2020
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17849 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17850 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jan 6, 2020
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17859 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@terryjreedy
Copy link
Member

First 3.7 backport suffered intermittent failure not related to IDLE. Auto-backport tests cannot be restarted, that I know of, so close and start over.

miss-islington added a commit that referenced this pull request Jan 6, 2020
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@taleinat taleinat deleted the minor-idle-docs-formatting branch May 26, 2020 12:14
@taleinat taleinat restored the minor-idle-docs-formatting branch May 26, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants