-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
bpo-38636: Fix IDLE tab toggle and file indent width #17008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These format menu functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled in 3.7.5 and 3.8.0.
I might eventually fix this a different way, but this is simple enough to apply by hand to existing 3.7.5 and 3.8.0 installations -- add a line and edit or replace the two that follow. I intend to add new tests before merging. |
This is such an obvious fix, I suggest just merging it. I'm not sure we should be automatically testing that all of our menu options work, anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The bug being fixed is a faulty binding, so I would one day like to test them automatically as well as manually (which I forgot here), but another time. I did want to finish the format module tests. Just waiting for CI. |
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
These Format menu functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled in 3.7.5 and 3.8.0. (cherry picked from commit b846247) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-17274 is a backport of this pull request to the 3.8 branch. |
These Format menu functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled in 3.7.5 and 3.8.0. (cherry picked from commit b846247) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-17275 is a backport of this pull request to the 3.7 branch. |
These Format menu functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled in 3.7.5 and 3.8.0.
These Format menu functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled in 3.7.5 and 3.8.0.
These format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
https://bugs.python.org/issue38636