bpo-25794: Fix type.__setattr__() for non-interned attribute names.
#1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on patch by Eryk Sun.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tim-one and @larryhastings to be potential reviewers. |
Objects/typeobject.c
Outdated
| return -1; | ||
| } | ||
| copied = 1; | ||
| assert(PyUnicode_CheckExact(name)); |
There was a problem hiding this comment.
Do we need another call to PyUnicode_CheckExact if PyUnicode_CheckExact(name) in line 3142 returns true?
| @@ -7090,6 +7115,9 @@ update_slot(PyTypeObject *type, PyObject *name) | |||
| slotdef **pp; | |||
| int offset; | |||
|
|
|||
| assert(PyUnicode_CheckExact(name)); | |||
| assert(PyUnicode_CHECK_INTERNED(name)); | |||
There was a problem hiding this comment.
I guess we can now remove the following comment in line 7131:
/* XXX assume name is interned! */
berkerpeksag
approved these changes
May 19, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 20, 2017
…names. (pythonGH-1652) Based on patch by Eryk Sun.. (cherry picked from commit d896985)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 20, 2017
…names. (pythonGH-1652) Based on patch by Eryk Sun.. (cherry picked from commit d896985)
|
Thank you for your review @berkerpeksag. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 20, 2017
…names. (pythonGH-1652) Based on patch by Eryk Sun.. (cherry picked from commit d896985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on patch by Eryk Sun.