Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Eric's TODO file into his directory. #16072

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Move Eric's TODO file into his directory. #16072

merged 1 commit into from
Sep 12, 2019

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Sep 12, 2019 •
edited by miss-islington
Loading

Automerge-Triggered-By: @benjaminp

ericsnowcurrently
ericsnowcurrently approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

@benjaminp: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@benjaminp benjaminp merged commit a44f3dc into python:master Sep 12, 2019
@benjaminp benjaminp deleted the eric-todo branch September 12, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjaminp @miss-islington @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot