bpo-30349: Raise FutureWarning for nested sets and set operations #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in regular expressions.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @rhettinger and @birkenfeld to be potential reviewers. |
serhiy-storchaka
changed the title
cryvate
reviewed
Oct 5, 2017
Doc/library/re.rst
Outdated
| @@ -201,6 +201,18 @@ The special characters are: | |||
| place it at the beginning of the set. For example, both ``[()[\]{}]`` and | |||
| ``[]()[{}]`` will both match a parenthesis. | |||
|
|
|||
| * The support of nested sets and set operations can be added in future. | |||
There was a problem hiding this comment.
Change to something like: "Support of nested sets and set operations as in Unicode ...[no idea what their equivalent name is for their 'peps'] 18 (link) might be added in the future. This would change the syntax, so to facilitate this change a :exc:FutureWarning will be raised in ambiguous cases for the time being."
cryvate
reviewed
Oct 5, 2017
Doc/library/re.rst
Outdated
| But that syntax is treated differently in the older versions of Python. | ||
| For avoiding a breakage a :exc:`FutureWarning` will be raised in the | ||
| meanwhile in ambiguous cases. | ||
| That incluse sets starting with a literal ``'['`` or containing literal |
cryvate
reviewed
Oct 5, 2017
Doc/library/re.rst
Outdated
| meanwhile in ambiguous cases. | ||
| That incluse sets starting with a literal ``'['`` or containing literal | ||
| character sequences ``'--'``, ``'&&'``, ``'~~'``, and ``'||'``. For | ||
| avoiding a warning escape them with a backslash. |
There was a problem hiding this comment.
"For avoiding a warning" -> "To avoid a warning"
|
Thanks @cryvate! |
jimmylai
added a commit
to jimmylai/cpython
that referenced
this pull request
Nov 17, 2017
* 'master' of https://github.com/python/cpython: (550 commits) bpo-31867: Remove duplicates in default mimetypes. (python#4388) tokenizer: Remove unused tabs options (python#4422) bpo-31691: Specify where to find build instructions for the Windows installer (python#4426) Fix typo in atexit documentation. (pythonGH-4419) bpo-31702: Allow to specify rounds for SHA-2 hashing in crypt.mksalt(). (python#4110) bpo-32043: New "developer mode": "-X dev" option (python#4413) bpo-30349: Raise FutureWarning for nested sets and set operations (python#1553) bpo-32037: Use the INT opcode for 32-bit integers in protocol 0 pickles. (python#4407) bpo-30143: 2to3 now generates a code that uses abstract collection classes (python#1262) bpo-32030: Enhance Py_Main() (python#4412) bpo-32030: Split Py_Main() into subfunctions (python#4399) bpo-32034: Make IncompleteReadError & LimitOverrunError pickleable python#4409 bpo-32025: Add time.thread_time() (python#4410) bpo-32018: Fix inspect.signature repr to follow PEP 8 (python#4408) bpo-30399: Get rid of trailing comma in the repr of BaseException. (python#1650) bpo-30950: Convert round() to Argument Clinic. (python#2740) bpo-32011: Revert "Issue python#15480: Remove the deprecated and unused TYPE_INT64 code from marshal." (python#4381) bpo-32023: Disallow genexprs without parenthesis in class definitions. (python#4400) bpo-31949: Fixed several issues in printing tracebacks (PyTraceBack_Print()). (python#4289) bpo-32032: Test both implementations of module-level pickle API. (python#4401) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in regular expressions.
https://bugs.python.org/issue30349