Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix punctuation in os.execvpe docstring. #15051

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fix punctuation in os.execvpe docstring. #15051

merged 1 commit into from
Sep 9, 2019

Conversation

hramezani
Copy link
Contributor

@hramezani hramezani commented Jul 31, 2019 •
edited
Loading

Fix punctuation in os.execvpe docstring.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

mangrisano
mangrisano approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@mangrisano mangrisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

hansrajdas
hansrajdas reviewed Aug 19, 2019
View reviewed changes
Lib/os.py
@@ -568,7 +568,7 @@ def execvpe(file, args, env):
"""execvpe(file, args, env)

Execute the executable file (which is searched for along $PATH)
with argument list args and environment env , replacing the
with argument list args and environment env, replacing the
current process.
args may be a list or tuple of strings. """
Copy link
Contributor

@hansrajdas hansrajdas Aug 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please remove extra space from end of doc string also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this extra space in all function docstring. for example:

cpython/Lib/os.py

Line 532 in 24fe460

current process. """

cpython/Lib/os.py

Line 555 in 24fe460

process. """

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, don't know this is intentional or what. In that case, we should take this trailing space removal in a separate PR. Thank you!

@zooba zooba merged commit fb6807b into python:master Sep 9, 2019
@miss-islington
Copy link
Contributor

Thanks @hramezani for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@hramezani @miss-islington
Fix punctuation in os.execvpe docstring. (pythonGH-15051)
293914e 
(cherry picked from commit fb6807b)

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@bedevere-bot
Copy link

GH-15799 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@hramezani @miss-islington
Fix punctuation in os.execvpe docstring. (pythonGH-15051)
331e5b8 
(cherry picked from commit fb6807b)

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@bedevere-bot
Copy link

GH-15800 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @hramezani
Fix punctuation in os.execvpe docstring. (GH-15051)
421ef39 
(cherry picked from commit fb6807b)

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @hramezani
Fix punctuation in os.execvpe docstring. (GH-15051)
15d263e 
(cherry picked from commit fb6807b)

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@hramezani @websurfer5
Fix punctuation in os.execvpe docstring. (pythonGH-15051)
8f9c5fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansrajdas hansrajdas hansrajdas approved these changes

@mangrisano mangrisano mangrisano approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hramezani @the-knights-who-say-ni @miss-islington @bedevere-bot @hansrajdas @mangrisano @zooba