bpo-15817: gdbinit: Document commands after defining them #15021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in GH-6384. (Note that the diff algorithm gets a bit confused by those changes - try running git diff --histogram for a more understandable output)
ammaraskar
approved these changes
Sep 7, 2019
There was a problem hiding this comment.
Can recreate this issue on GDB 7.7.1 and this patch fixes the problem. I'm guessing the patch was tested on an old version of gdb that didn't require the command to exist.
Long term, I question the utility of maintaining the gdbinit file considering it was broken for a year and no one complained.
|
I trust @ammaraskar's review of this; @smontanaro, @abalkin, I'll merge this tomorrow if you don't object before then. |
|
Thank you for the patch, @The-Compiler, and thanks for the review @ammaraskar! |
|
Thanks @The-Compiler for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @The-Compiler and @zware, I had trouble checking out the |
zware
pushed a commit
to zware/cpython
that referenced
this pull request
Sep 9, 2019
…onGH-15021) The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in pythonGH-6384. (cherry picked from commit 1f86fdc) Co-authored-by: Florian Bruhin <me@the-compiler.org>
|
GH-15744 is a backport of this pull request to the 3.8 branch. |
zware
added a commit
that referenced
this pull request
Sep 9, 2019
…5021) (#15744) The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in GH-6384. (cherry picked from commit 1f86fdc) Authored-by: Florian Bruhin <me@the-compiler.org>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…5021) The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in pythonGH-6384.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…5021) The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in pythonGH-6384.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…5021) The gdb manual[1] says the following for "document": The command commandname must already be defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html And indeed when trying to use the gdbinit file with gdb 8.3, I get: .../cpython/Misc/gdbinit:17: Error in sourced command file: Undefined command: "pyo". Try "help". Fix this by moving all documentation blocks after the define blocks. This was introduced in pythonGH-6384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gdb manual says the following for "document":
And indeed when trying to use the gdbinit file with gdb 8.3, I get:
Fix this by moving all documentation blocks after the define blocks.
This was introduced in GH-6384 (cc @smontanaro / @abalkin).
(Note that the diff algorithm gets a bit confused by those changes - try running
git diff --histogramfor a more understandable output. Also, note I took the freedom to re-use the issue number of the original implementation, hope that's okay.)https://bugs.python.org/issue15817