-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-29446: IDLE -- add explicit imports #14919
Conversation
Stop depending on tkinter import *.
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Stop depending on tkinter import *. (cherry picked from commit c6fd6c8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-14920 is a backport of this pull request to the 3.8 branch. |
Stop depending on tkinter import *. (cherry picked from commit c6fd6c8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-14921 is a backport of this pull request to the 3.7 branch. |
|
@taleinat @vstinner This buildbot IDLE test failure is a false positive that coincidentally occurred when testing another, trivial, IDLE change. What this report omits is that the test passed on the retest. The test that failed is a year old, written by Tal. (ENV CHANGED is from test_multiprocessing_spawn.) Victor: Have you seen this failure before. Also, I thought the point of retest was to ignore transient failures like this? |
I forgot about seeing this before. See issue 35771. |
Stop depending on tkinter import *.
Stop depending on tkinter import *.
Stop depending on tkinter import *.
Stop depending on tkinter import *.
https://bugs.python.org/issue29446