bpo-37609: Add device path support in ntpath splitdrive

[nsiregar]

Add device path support in ntpath.splitdrive

https://bugs.python.org/issue37609

[ZackerySpytz]

Using the mod role here is not correct. Please see https://devguide.python.org/documenting/#id4.

[nsiregar]

Thanks, I've updated it to use meth.

[ZackerySpytz]

It should be func.

[nsiregar]

Thanks, I've updated it

[zooba]

Sorry for not seeing this earlier, I have a few general suggestions:

• put a leading underscore on the new functions (or else add full documentation for them)
• use constant strings in the comparisons, rather than sep*2
• add some tests using backslashes as well, not just forward slashes

[eryksun]

These functions are clearly private (e.g. parameterized by sep and colon), so the function names should have a leading underscore.

[nsiregar]

working on it

[eryksun]

For an alternate and more complete implementation, see the splitdrive.py file that I attached to bpo-37609.

[barneygale]

I managed to fix the issue elsewhere (in #91882), so I'm going to close this PR, but thank you very much for taking a look at it! :)