bpo-37521: No longer treat insertion into sys.modules as optional in importlib examples #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettcannon: Status check is done, and it's a success ✅ . |
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-14724 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2019
…importlib examples (pythonGH-14723) Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module(). Thanks to Benjamin Mintz for finding the bug. https://bugs.python.org/issue37521 (cherry picked from commit 0827064) Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jul 12, 2019
…al in importlib examples (GH-14723) (GH-14724) Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module(). Thanks to Benjamin Mintz for finding the bug. https://bugs.python.org/issue37521 (cherry picked from commit 0827064) Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com> https://bugs.python.org/issue37521
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…importlib examples (pythonGH-14723) Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module(). Thanks to Benjamin Mintz for finding the bug. https://bugs.python.org/issue37521
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…importlib examples (pythonGH-14723) Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module(). Thanks to Benjamin Mintz for finding the bug. https://bugs.python.org/issue37521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module().
Thanks to Benjamin Mintz for finding the bug.
https://bugs.python.org/issue37521