gh-139109: Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT optiimizer#144394
Conversation
cocolato
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good generally.
I suspect that using ADD_OP and REPLACE_OP together may be broken, but that won't matter if we make _CHECK_STACK_SPACE_OPERAND only check stack space.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
This looks good now, thanks.
…E_OPERAND` in JIT optiimizer (pythonGH-144394)
2 participants
Refer: #144388
This implements a simple one-to-one replacement of
_CHECK_STACK_SPACEwith_CHECK_STACK_SPACE_OPERANDin the JIT optimizer.Also open and rewrite all the tests that are disabled in #139109.