gh-143361: Pass PY_VECTORCALL_ARGUMENTS_OFFSET in _Py_CallBuiltinClass_StackRefSteal#143367
Merged
Fidget-Spinner merged 3 commits intopython:mainfrom Jan 2, 2026
Merged
Conversation
Misc/NEWS.d/next/Core_and_Builtins/2026-01-02-17-11-16.gh-issue-143361.YDnvdC.rst
Outdated
Show resolved
Hide resolved
…e-143361.YDnvdC.rst
Fidget-Spinner
approved these changes
Jan 2, 2026
Member
There was a problem hiding this comment.
I don't think we need this, this is internal.
Contributor
Author
There was a problem hiding this comment.
I mentally went back and forth on this. It's true that guideline is that "strictly internal changes with no user-visible effects" do not warrant an entry. My reasoning for inclusion was that a 3.9% speedup in a core code path is indeed significant enough to external, end-users that this change warrants an entry. It also seems to be how this sort of change in ceval.c. has been handled in the past. However, I’ll gladly defer to the guidance of the core developers who review the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a missed optimization.
The function
_Py_CallBuiltinClass_StackRefStealusesSTACKREFS_TO_PYOBJECTS. However, the code was not passing thePY_VECTORCALL_ARGUMENTS_OFFSETflag to the callee. This forced vector-callable types to reallocate and copy the arguments whenever they needed to prepend an argument.Verification
Using LLDB to inspect
long_vectorcallwhen reached via this path:nargsf = 1nargsf = 0x8000000000000001(High bit correctly set)Benchmarks
I ran a small benchmark file allocating a class in a tight loop to trigger the path:
gh-143361
Benchmark script