Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows release builds in Azure Pipelines #14065

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Jun 13, 2019

This automates most of the Windows Release build in a single (multi-stage) Azure Pipelines job.

You can see a sample run at https://dev.azure.com/python/cpython/_build/results?buildId=45280&view=results

It still requires my custom build machine to be running, but only when SigningCertificate is set. Without this, and without UsePGO, it should all run on hosted machines.

The final publish steps are currently not implemented, as they weren't previously anyway (other than Nuget). I expect to leave them unimplemented for now, and just won't use them, but eventually may come around to automating it the whole way through.

Once you get past the .yml files, there are actual changes to the build files. I found it convenient to generate more files at build (e.g. LICENSE.txt) rather than doing it as part of setup. There shouldn't be anything dramatic in here, and it obviously all works with the release build process or I wouldn't be posting yet :)

@asvetlov
Copy link
Contributor

Side question.
Does azure look on .azure-piplenes folder or .azure-pipelines.yml?
What files are used as entrypoints for the folder case?

I've tried to search using google and azure pipelines documentation site embedded searcher but found nothing

@zooba
Copy link
Member Author

zooba commented Jun 14, 2019

@asvetlov It's totally customizable. We have multiple build definitions configured for this repo - one using .azure-pipelines/ci.yml, one for .azure-pipelines/pr.yml and now one for .azure-pipelines/windows-release.yml.

If you use azure-pipelines.yml in the root directory, then it will be automatically detected when you add the repo. But it's only a default.

@zooba
Copy link
Member Author

zooba commented Jun 14, 2019

You should be able to see all the builds at https://dev.azure.com/python/cpython/_build

I also have a few manually created ones for building the OpenSSL and libffi bits that we use.

@zooba zooba merged commit 21a92f8 into python:master Jun 14, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 21a92f8cda525d25a165b773fbe1bfffd303a000 3.8

@bedevere-bot
Copy link

GH-14085 is a backport of this pull request to the 3.8 branch.

@asvetlov
Copy link
Contributor

@zooba thanks.
Now I figured out that I can use a path to pipeline in azure pipelines settings UI.
I've missed that point.

zooba added a commit that referenced this pull request Jun 14, 2019
$(PySourcePath)PC\crtlicense.txt;
$(bz2Dir)LICENSE;
$(opensslOutDir)LICENSE;
$(tcltkDir)tcllicense.terms;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zooba This change breaks building with --no-tkinter. Which breaks the Windows arm32 buildbot

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants