gh-140126: Fix compile error if --with-assertions is enabled.#140133
Merged
vstinner merged 1 commit intopython:mainfrom Oct 14, 2025
Merged
gh-140126: Fix compile error if --with-assertions is enabled.#140133vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
The `types_world_is_stopped()` function needs to be defined if NDEBUG is not defined.
vstinner
approved these changes
Oct 14, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I confirm that ./configure --disable-gil --with-assertions build fails without this change and succeed with this change.
Member
|
Merged, thanks. |
This was referenced Nov 28, 2025
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ython#140133) The `types_world_is_stopped()` function needs to be defined if NDEBUG is not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
types_world_is_stopped()function needs to be defined if NDEBUG is not defined.--disable-gil --with-assertions:Objects/typeobject.c:123:13: error: implicit declaration of function ‘types_world_is_stopped’ [-Wimplicit-function-declaration]#140126