Skip to content

gh-139312: Update bundled libexpat to 2.7.3 #139319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2025
Merged

gh-139312: Update bundled libexpat to 2.7.3 #139319

merged 4 commits into from
Sep 27, 2025
+58 −35

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 25, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 25, 2025
Open
@sethmlarson sethmlarson mentioned this pull request Sep 25, 2025
Closed
sethmlarson
sethmlarson requested changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the code looks fine, however the tarball checksum and versions of the expat SBOM aren't updated. This wasn't caught automatically (which I've fixed in #139331) but this PR should have the correct values before being backported.

@StanFromIreland StanFromIreland added DO-NOT-MERGE needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 25, 2025
sethmlarson
sethmlarson approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gpshead gpshead merged commit 48d0d0d into python:main Sep 27, 2025
50 of 51 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2025
@StanFromIreland @miss-islington
pythongh-139312: Update bundled libexpat to 2.7.3 (pythonGH-139319)
487a75e 
+ Blurb
+ Update sbom.spdx.json
(cherry picked from commit 48d0d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2025
@StanFromIreland @miss-islington
pythongh-139312: Update bundled libexpat to 2.7.3 (pythonGH-139319)
2164636 
+ Blurb
+ Update sbom.spdx.json
(cherry picked from commit 48d0d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @StanFromIreland and @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 48d0d0dd9733eae4935f2ebd31bef786d8074fc8 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2025

GH-139376 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 27, 2025
@miss-islington-app
Copy link

Sorry, @StanFromIreland and @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 48d0d0dd9733eae4935f2ebd31bef786d8074fc8 3.11

@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2025

GH-139377 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2025
@miss-islington-app
Copy link

Sorry, @StanFromIreland and @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 48d0d0dd9733eae4935f2ebd31bef786d8074fc8 3.10

hugovk pushed a commit that referenced this pull request Sep 27, 2025
@miss-islington @StanFromIreland
[3.14] gh-139312: Update bundled libexpat to 2.7.3 (GH-139319) (#139376)
5761773 
gh-139312: Update bundled libexpat to 2.7.3 (GH-139319)

(cherry picked from commit 48d0d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request Sep 27, 2025
@miss-islington @StanFromIreland
[3.13] gh-139312: Update bundled libexpat to 2.7.3 (GH-139319) (#139377)
a461f25 
gh-139312: Update bundled libexpat to 2.7.3 (GH-139319)

+ Blurb
+ Update sbom.spdx.json
(cherry picked from commit 48d0d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the update-libexpat branch September 27, 2025 08:20
@StanFromIreland
Copy link
Member Author

3.12 backport has to wait for #139026

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 27, 2025
@StanFromIreland
[3.11] pythongh-139312: Update bundled libexpat to 2.7.3 (pythonGH-13…
b3ea132 
…9319)

(cherry picked from commit 48d0d0d)

# Conflicts:
#	Misc/sbom.spdx.json
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2025

GH-139378 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 27, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 27, 2025
@StanFromIreland
[3.11] pythongh-139312: Update bundled libexpat to 2.7.3 (pythonGH-13…
1fe9b26 
…9319)

(cherry picked from commit 48d0d0d)
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2025

GH-139379 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Sep 27, 2025
pablogsal pushed a commit that referenced this pull request Sep 28, 2025
@StanFromIreland
[3.11] gh-139312: Update bundled libexpat to 2.7.3 (GH-139319) (#139378)
6cb1649
pablogsal pushed a commit that referenced this pull request Sep 28, 2025
@StanFromIreland
[3.10] gh-139312: Update bundled libexpat to 2.7.3 (GH-139319) (#139379)
7252d2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees

@StanFromIreland StanFromIreland

Labels
needs backport to 3.12 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @gpshead @sethmlarson