Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @maxking to CODEOWNERS file #13599

Merged
merged 1 commit into from
May 28, 2019
Merged

Conversation

maxking
Copy link
Contributor

@maxking maxking commented May 27, 2019

No description provided.

@Mariatta
Copy link
Member

Hmm we've never tried adding non core developers into CODEOWNERS yet, so I'm not sure if this will work. The effect of codeowners file is that you will be automatically requested review for the matched PR, and I don't know if we can request review from people outside of Python org.

But anyway, let's try this, and we can always revert the change.

@Mariatta Mariatta changed the title Add myself to CODEOWNERS for email module. Add @maxking to CODEOWNERS file May 28, 2019
@miss-islington miss-islington merged commit 71dc7c5 into python:master May 28, 2019
@maxking maxking deleted the codeowner branch May 28, 2019 04:20
@maxking
Copy link
Contributor Author

maxking commented May 28, 2019

Thanks @Mariatta ! Now all I need to do is open a PR and see if it works ;-)

@tirkarthi
Copy link
Member

https://help.github.com/en/articles/about-code-owners

People with admin or owner permissions can set up a CODEOWNERS file in a repository. The people you choose as code owners must have write permissions for the repository.

brettcannon added a commit that referenced this pull request May 28, 2019
@brettcannon
Copy link
Member

I opened #13660 to revert this since @tirkarthi found that reference saying @maxking would need to have write access to get notifications.

Maybe once the new "triage" access is launched that will work with CODEOWNERS and then we can give @maxking that level of access.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants