gh-135532: cleanup clinic module directives for cryptographic modules
#135822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 31f8b90 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135822%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz
force-pushed
the
fix/hashlib/clinic-directives-135532
branch
from
fb57604 to
cc31a2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly speaking, we have bugs, but since I moved pieces around, I won't backport it. Considering old branches won't get new features for those modules, this will become dead code anyway.
Now, I'm so tempted to change the names of the functions because it's annoying to think about it when navigating through the different modules, but I will resist in this PR. I haven't touched at the headers (though I wanted to) but I'll do it in a follow-up PR because I'll use
_PyType_GetModuleStateconsistently.