Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36983: Fix typing.__all__ and add test for exported names #13456

Merged
merged 1 commit into from
May 29, 2019
Merged

bpo-36983: Fix typing.__all__ and add test for exported names #13456

merged 1 commit into from
May 29, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented May 21, 2019 •
edited by bedevere-bot
Loading

@Carreau
Copy link
Contributor

Carreau commented May 29, 2019

(also will need a rebase/fix conflicts.)

@asottile asottile force-pushed the typing_all_bpo-36983 branch from cb7699d to 587dc7a Compare May 29, 2019 03:40
@miss-islington miss-islington merged commit d30da5d into python:master May 29, 2019
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Will retry in 1 minute. Retry # 1

@asottile asottile deleted the typing_all_bpo-36983 branch May 29, 2019 18:59
@bedevere-bot
Copy link

GH-13662 is a backport of this pull request to the 3.7 branch.

asottile added a commit to asottile/cpython that referenced this pull request May 29, 2019
@asottile
bpo-36983: Fix typing.__all__ and add test for exported names (python…
076236c 
…GH-13456)

https://bugs.python.org/issue36983
@bedevere-bot
Copy link

GH-13663 is a backport of this pull request to the 3.6 branch.

asottile added a commit to asottile/cpython that referenced this pull request May 29, 2019
@asottile
bpo-36983: Fix typing.__all__ and add test for exported names (python…
cb74eb5 
…GH-13456)

https://bugs.python.org/issue36983
miss-islington pushed a commit that referenced this pull request May 30, 2019
@asottile @miss-islington
[3.7] bpo-36983: Fix typing.__all__ and add test for exported names (G…
3a98bbf 
…H-13456) (GH-13662)

https://bugs.python.org/issue36983

Fixes issue 36983
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asottile @DinoV
bpo-36983: Fix typing.__all__ and add test for exported names (python…
e202da1 
…GH-13456)

https://bugs.python.org/issue36983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asottile @Carreau @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni