Docs EPUB: fix meta tags connected with Open Graph#134071
Docs EPUB: fix meta tags connected with Open Graph#134071m-aciek wants to merge 2 commits intopython:mainfrom
Conversation
For EPUB builds validity.
|
Do meta tags even make sense for EPUB (and other builders)? If not, it's probably better to skip them altogether for those builders. Could save us future headaches as well. |
It looks like they don't. https://chatgpt.com/share/6827445c-70f0-8004-bed3-353546e96afa sphinx-doc/sphinxext-opengraph#137 @methane started the implementation of skipping them on the extension side. |
I'd prefer an authoritative source rather than a webpage that says "ChatGPT can make mistakes. Check important info." |
I wasn't able to confirm that searching manually in a limited time. |
|
The epub download is still broken. |
|
Can we add a conditional in |
In my opinion the cleanest would be to have it in Probably we could leverage tags to put this logic in |
|
Can we please do as suggested at #134071 (comment) above? It is painful not to be able to read the Python EPUB docs. |
|
@cclauss Would you like to open a PR? |
|
I would have opened a PR a long time ago if I knew how to fix this problem. |
|
Closing in favor of #136187. |
|
This is GREAT!!! Thank you so much!! |
|
@MenszgUD0ker
ในวันที่ พฤ. 14 ส.ค. 2025 15:13 น. Christian Clauss <
***@***.***> เขียนว่า:
… *cclauss* left a comment (python/cpython#134071)
<#134071 (comment)>
This is GREAT!!! Thank you so much!!
—
Reply to this email directly, view it on GitHub
<#134071 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7Q3DZSKPV5O5GDS7ECPGHD3NRALTAVCNFSM6AAAAAB5HKJHBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBXGQYDSNBQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
theme-colortag fromsphinxext-opengraphcustom tags config directly tolayout.html. Previously it would be added for all HTML-related Sphinx builders, after it's only added when builder == HTML.sphinxext-opengraphconfig. (I've opened Custom tags and EPUB builder sphinx-doc/sphinxext-opengraph#136 to discuss alternative fixes.)It's a follow-up to #132220 and #133720. This change should fix EPUB builds. When testing locally for #133720 I didn't have
sphinxext-opengraphinstalled in the environment, that's why I didn't catch it earlier, I'm sorry.Could we please backport it for supported versions and 3.12?
Before:
After:
📚 Documentation preview 📚: https://cpython-previews--134071.org.readthedocs.build/