-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-131942: Use the Python-specific Py_DEBUG
macro rather than _DEBUG
in Windows-related C code
#131944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ows-related C code
Py_DEBUG
macro rather than _DEBUG
in Windows-related C codePy_DEBUG
macro rather than _DEBUG
in Windows-related C code
Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the documentation isn't required, but if you're going to, we should document the Windows behaviour on the same level as the Unix behaviour (that is, don't put it in a "note"), and should also make the whole section make sense.
Apologies for the delays, and thanks for the updates. Once CI passes, this will merge automatically. Thanks! |
Changes:
Py_DEBUG
inPC/pyconfig.h.in
to the top of the file._DEBUG
toPy_DEBUG
by using the regex/\b_DEBUG\b/
.make regen-all
.Since the
sysconfig.h
is included in all C headers with top precedence. This PR does not have any user-side visible changes.cpython/Include/Python.h
Lines 5 to 15 in 4940d96
Resolves #131942
Py_DEBUG
macro rather than_DEBUG
in Windows-related C code #131942