Skip to content

gh-129368: In PyRun C API docs, clarify what a "start token" is #129935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

iamrajhans
Copy link

@iamrajhans iamrajhans commented Feb 10, 2025

@ghost
Copy link

ghost commented Feb 10, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@iamrajhans
Copy link
Author

@erlend-aasland could you please review this, thanks !

@@ -183,7 +183,7 @@ the same library that the Python runtime is using.
objects *globals* and *locals* with the compiler flags specified by
*flags*. *globals* must be a dictionary; *locals* can be any object
that implements the mapping protocol. The parameter *start* specifies
the start token that should be used to parse the source code.
the start symbol that should be used to parse the source code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also provide a link to Py_eval_input, so the user does not have to search through this page in order to find out what a "start symbol" is :)

@erlend-aasland erlend-aasland changed the title gh-129368: fix doc - use start symbol instead of start token gh-129368: In PyRun C API docs, clarify what a "start token" is May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants