Skip to content

gh-129819: Allow tier2/JIT and tailcall #129820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 12, 2025
Merged

gh-129819: Allow tier2/JIT and tailcall #129820

merged 8 commits into from
Feb 12, 2025

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 7, 2025 •
edited by bedevere-app bot
Loading

This is just a patch to support JIT with tail calls. The real unifying comes after this.

@bedevere-app bedevere-app bot mentioned this pull request Feb 7, 2025
Open
@Fidget-Spinner
Copy link
Member Author

Skipping news, as this has not yet been in a released version of Python.

brandtbucher
brandtbucher reviewed Feb 11, 2025
View reviewed changes
@Fidget-Spinner Fidget-Spinner mentioned this pull request Feb 12, 2025
Closed
brandtbucher
brandtbucher approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, haven't tried it locally though (and I don't think it's tested in CI). Can you try it out?

@Fidget-Spinner
Copy link
Member Author

Code looks good, haven't tried it locally though (and I don't think it's tested in CI). Can you try it out?

Yup I built it locally and it works.

@Fidget-Spinner Fidget-Spinner merged commit 1b27f36 into python:main Feb 12, 2025
46 checks passed
@Fidget-Spinner Fidget-Spinner deleted the allow-tier2-and-tailcall branch February 12, 2025 18:18
@zanieb zanieb mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fidget-Spinner @brandtbucher