[3.13] gh-71339: Add additional assertion methods in test.support (GH-128707) #128815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
tests
serhiy-storchaka
requested review from
JelleZijlstra,
AlexWaygood,
jaraco,
warsaw,
FFY00 and
vsajip
as code owners
serhiy-storchaka
changed the title
…honGH-128707) Add a mix-in class ExtraAssertions containing the following methods: * assertHasAttr() and assertNotHasAttr() * assertIsSubclass() and assertNotIsSubclass() * assertStartsWith() and assertNotStartsWith() * assertEndsWith() and assertNotEndsWith() (cherry picked from commit 06cad77)
serhiy-storchaka
force-pushed
the
extra-assertions-3.13
branch
from
6f77663 to
ab80b68
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jan 20, 2025
…t.support (pythonGH-128707) (pythonGH-128815) Add a mix-in class ExtraAssertions containing the following methods: * assertHasAttr() and assertNotHasAttr() * assertIsSubclass() and assertNotIsSubclass() * assertStartsWith() and assertNotStartsWith() * assertEndsWith() and assertNotEndsWith() (cherry picked from commit c6a566e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 06cad77)
|
GH-129059 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 20, 2025
…-128707) (GH-128815) (GH-129059) Add a mix-in class ExtraAssertions containing the following methods: * assertHasAttr() and assertNotHasAttr() * assertIsSubclass() and assertNotIsSubclass() * assertStartsWith() and assertNotStartsWith() * assertEndsWith() and assertNotEndsWith() (cherry picked from commit c6a566e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 06cad77)
jaraco
reviewed
Jan 26, 2025
| @@ -28,7 +29,7 @@ def anchor02(self): | |||
| return importlib.import_module('data02') | |||
|
|
|||
|
|
|||
| class FunctionalAPIBase(util.DiskSetup): | |||
| class FunctionalAPIBase(util.DiskSetup, ExtraAssertions): | |||
There was a problem hiding this comment.
The change in this file is going to be overwritten unless ported over to importlib_resources (and backported to support Python 3.9).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mix-in class ExtraAssertions containing the following methods:
(cherry picked from commit 06cad77)
This will help to backport new tests that use new assertion methods.